[Patterns]: Load theme patterns only in block and site editor #39493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
jsnajdr
approved these changes
Mar 16, 2022
Mamaduka
approved these changes
Mar 16, 2022
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
It makes sense. Core also loads patterns right after the is_block_editor set to true.
ntsekouras
force-pushed
the
update/load-theme-patterns-only-when-needed
branch
from
089a421 to
ac9298f
Compare
This was referenced Mar 17, 2022
Contributor
|
Just a heads up that this seems to break any block patterns that were registered on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Load theme patterns only in block and site editor
Why?
From @jsnajdr 's comment:
How?
This PR adds checks to fetch/register them only in block and site editor.